Text message showing up as my email address iPhone 4

If you used your email address as the AppleID you use for iMessage, you can't fix it. It is working as designed.

I was able to fix it, under "settings"-"messages" I clicked on "receive at" and then clicked on my apple id and logged out. Now it's showing up as my phone number.

That's not really fixed, all you've done is stopped people from being able to send iMessages to your AppleID. If you don't intend to use iMessage with a Mac, iPad or iPod touch (any non-iPhone device) then I guess that's ok - but most people with multiple devices want to recieve messages no matter what they are using.